Fixes and improvement for 0.1.8 #11

lamhoangtung · 2020-09-25T06:44:23Z

This contain various fixes and improvement for the next release (0.1.8) of MLChain.

Strip down dependencies to avoid issue like ImportError: cannot import name 'InvalidDataError' from 'hyperframe.exceptions' #7
Introduce more unittest to test more feature and increase code coverage check (it's around 50% now) Increase code coverage for testing #8
Detach image from base64, compress HTML template to reduce web code footprint Compress Swagger HTML for smaller web asset footprint #9
Fixed an issue when MLChain fail to parse the workers config for gunicorn and hypercorn
Remove torch set thread from mlchain warper since that is practically useless
Remove dead code, assest, unnecessary warning
Better long description for PyPI README

…homepage

codecov-commenter · 2020-09-25T06:52:19Z

Codecov Report

Merging #11 into master will increase coverage by 28.02%.
The diff coverage is 65.21%.

@@             Coverage Diff             @@
##           master      #11       +/-   ##
===========================================
+ Coverage   21.42%   49.44%   +28.02%     
===========================================
  Files          46       44        -2     
  Lines        3622     3610       -12     
===========================================
+ Hits          776     1785     +1009     
+ Misses       2846     1825     -1021

Impacted Files	Coverage Δ
mlchain/config.py	`52.71% <40.00%> (+11.76%)`	⬆️
mlchain/cli/run.py	`65.28% <50.00%> (+65.28%)`	⬆️
mlchain/cli/main.py	`93.33% <80.00%> (+93.33%)`	⬆️
mlchain/__init__.py	`100.00% <100.00%> (+6.25%)`	⬆️
mlchain/cli/init.py	`84.61% <100.00%> (+84.61%)`	⬆️
mlchain/client/__init__.py	`48.78% <100.00%> (+29.73%)`	⬆️
mlchain/__main__.py
mlchain/server/grpc_server.py	`35.08% <0.00%> (+3.50%)`	⬆️
mlchain/workflows/pipeline.py	`25.20% <0.00%> (+8.13%)`	⬆️
mlchain/server/quart_server.py	`25.93% <0.00%> (+10.15%)`	⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 664ac1e...3941555. Read the comment docs.

lamhoangtung added 30 commits September 23, 2020 17:09

Remove dead code

5091356

Compress swagger html

92918c3

Detach base64 img to file to reduce html footprint on mlchain server …

f6997fb

…homepage

Trying to strip down mlchain dependencies

8a6ec59

Still trying

baaf1e7

turn grpc on

e084a29

Minor travis config fix

0ac03e5

Set version 0.1.7 for cli --version

157ead2

Fix yaml loader deprecated

8c6a191

Remove useless warning

2da43c2

Fixed parser worker config bugs

f817ad8

Add missing dep for fuzzywuzzy

22c7ec2

Remove dead file

2922805

Better long description for PYPI

9bc7e24

Fixed workers config bug with quart and hypercorn

d7aec6f

Minor

5328f5b

Let user set torch thread for multiprocessing on their own

2935345

Minor CLI fix

1c84034

Dont check coverage for tests

7127771

Minor

5188112

Avoid leaving unclose resource

72dcd0c

Minor

fa2f2a4

PEP8 old test

4b2340a

Much more unit test and better code coverage

1c0ab5b

exclude other lib from coverage check

342d69a

macos test tune

f1e90cd

oh shit

4887328

Test more serializer

042d02a

Auto switch off gunicorn on Windows

5d319af

Turn off some test for windows

24e547c

Add codecov config to turn off coverage check on patch

3941555

lamhoangtung added the enhancement New feature or request label Sep 25, 2020

lamhoangtung requested a review from meocong September 25, 2020 06:44

lamhoangtung self-assigned this Sep 25, 2020

lamhoangtung merged commit d8b107c into master Sep 25, 2020

lamhoangtung deleted the #7_fix branch September 25, 2020 07:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes and improvement for 0.1.8 #11

Fixes and improvement for 0.1.8 #11

lamhoangtung commented Sep 25, 2020 •

edited

Loading

codecov-commenter commented Sep 25, 2020 •

edited

Loading

Fixes and improvement for 0.1.8 #11

Fixes and improvement for 0.1.8 #11

Conversation

lamhoangtung commented Sep 25, 2020 • edited Loading

codecov-commenter commented Sep 25, 2020 • edited Loading

Codecov Report

lamhoangtung commented Sep 25, 2020 •

edited

Loading

codecov-commenter commented Sep 25, 2020 •

edited

Loading